chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:

https://www.npmjs.com/package/aws-polly-voices

MIT License

4 stars 17 forks source link

add .nvmrc and fix node version to 10.16.3 #17

Closed RanjithaShankar closed 4 years ago

RanjithaShankar commented 4 years ago

Proposed changes

add .nvmrc and fix node version to 10.16.3 This resolves issue #13

Types of changes

What types of changes does your code introduce to Appium? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

codecov-io commented 4 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          33     33           
  Branches        3      3           
=====================================
  Hits           33     33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 371041f...1ec6df3. Read the comment docs.

RanjithaShankar commented 4 years ago

Got it. I have made the changes.

chgasparoto commented 4 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: