chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:

https://www.npmjs.com/package/aws-polly-voices

MIT License

4 stars 17 forks source link

feat: add Spanish helper method #46

Closed MasihTak closed 3 years ago

MasihTak commented 4 years ago

Proposed changes

Added Spanish helper method fix #32

Types of changes

What types of changes does your code introduce to Appium? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

MasihTak commented 4 years ago

Hi @chgasparoto sorry for that, I fixed the issue.

codecov-io commented 4 years ago

Codecov Report

Merging #46 (19f2ba6) into master (cd15e28) will increase coverage by 100.00%. The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           master       #46        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%     
=============================================
  Files           0         1         +1     
  Lines           0        39        +39     
  Branches        0         3         +3     
=============================================
+ Hits            0        39        +39

Impacted Files	Coverage Δ
src/index.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd15e28...50225f9. Read the comment docs.

chgasparoto commented 4 years ago

@masihtak please update the README.md file with your implementation.

chgasparoto commented 4 years ago

Code looks good, you just need to fix the conflict with README.md file, please.

MasihTak commented 4 years ago

What changes needed for the README.md file ? I already added implementation

chgasparoto commented 4 years ago

@masihtak you are right, there's no implementation to do but there are conflicts to be resolved before the merge. See below 👇

MasihTak commented 4 years ago

It's because branch, isn't?

chgasparoto commented 4 years ago

yes, I've merged other branches into master, so it's normal to get some conflicts.

MasihTak commented 4 years ago

So what should I do? should I make new request?

chgasparoto commented 4 years ago

I'll wait one more week for the conflict fix otherwise I'm going to close it 😉

chgasparoto commented 3 years ago

:tada: This PR is included in version 1.20.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: