chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:

https://www.npmjs.com/package/aws-polly-voices

MIT License

4 stars 17 forks source link

feat: add a helper for french language #47

Closed lahgolz closed 5 years ago

lahgolz commented 5 years ago

fix #41

Proposed changes

Add a helper for the french language.

Types of changes

What types of changes does your code introduce to Appium? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

codecov-io commented 5 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          42     43    +1     
  Branches        3      3           
=====================================
+ Hits           42     43    +1

Impacted Files	Coverage Δ
src/index.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e160ae8...f100cbd. Read the comment docs.

lahgolz commented 5 years ago

No problem, I change that :3

lahgolz commented 5 years ago

Oh, sorry, this isn't a very clean work with Git...

chgasparoto commented 5 years ago

@EnderDragonneau I just merged other PR into master. Could you please fix the conflict?

lahgolz commented 5 years ago

Conflicts are now resolved !

chgasparoto commented 5 years ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lahgolz commented 5 years ago

Hurray! I'm glad to have been able to contribute to the project :3 Thank you!