chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:
https://www.npmjs.com/package/aws-polly-voices
MIT License
4 stars 17 forks source link

feat: add helper for Icelandic language #52

Closed merelyAnna closed 4 years ago

merelyAnna commented 4 years ago

fix #36 : Add a helper method for Icelandic language

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

codecov-io commented 4 years ago

Codecov Report

Merging #52 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #52   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          46     47    +1     
  Branches        3      3           
=====================================
+ Hits           46     47    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db11e84...2c7f799. Read the comment docs.

merelyAnna commented 4 years ago

@chgasparoto Changed the things as requested

chgasparoto commented 4 years ago

@merelyAnna still missing check the item on line 180 on README.md file :)

merelyAnna commented 4 years ago

@chgasparoto facepalm Of course. Sorry. Fixed it. :)

chgasparoto commented 4 years ago

@merelyAnna I just merged other PR into master. Could you please fix the conflict?

merelyAnna commented 4 years ago

@chgasparoto Done :)

chgasparoto commented 4 years ago

:tada: This PR is included in version 1.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: