chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:
https://www.npmjs.com/package/aws-polly-voices
MIT License
4 stars 17 forks source link

feat(component): implemented helper method for MEXICAN SPANISH #58

Closed AvgoustisW closed 4 years ago

AvgoustisW commented 4 years ago

implemented a helper method for MEXICAN SPANISH fix issue #35

Add a helper method for Mexican Spanish

Proposed changes

Hello, I have implemented Mexican Spanish helper to get into the GitHub flow and Hacktoberfest, have a good one and thanks for doing this!

Types of changes

What types of changes does your code introduce to Appium? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

mexican_spanish

codecov-io commented 4 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #58   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          44     45    +1     
  Branches        3      3           
=====================================
+ Hits           44     45    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b596b0...8160deb. Read the comment docs.

AvgoustisW commented 4 years ago

Hello chgasparoto,

I suppose this has been finished : )

Let me know and thanks!

chgasparoto commented 4 years ago

@AvgoustisW I just merged other PR into master. Could you please fix the conflict?

Please, in order to fix the issue automatically put fix #issue_number

AvgoustisW commented 4 years ago

@AvgoustisW I just merged other PR into master. Could you please fix the conflict?

Please, in order to fix the issue automatically put fix #issue_number

Conflict has been fixed. I am not sure I entirely understand what you mean by putting the fix #issue number. I have it on my PR description.

Let me know, and thanks!

chgasparoto commented 4 years ago

:tada: This PR is included in version 1.11.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

chgasparoto commented 4 years ago

@AvgoustisW what I meant: fix issue #issue_number (like in your PR description) doesn't work. You must put it like this: fix #issue_number. Now I have to close the issue manually :)

do you get it?