chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:

https://www.npmjs.com/package/aws-polly-voices

MIT License

4 stars 17 forks source link

feat: add helper for Spanish US language #60

Closed redahas closed 4 years ago

redahas commented 4 years ago

fix #33

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

codecov-io commented 4 years ago

Codecov Report

Merging #60 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          43     44    +1     
  Branches        3      3           
=====================================
+ Hits           43     44    +1

Impacted Files	Coverage Δ
src/index.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 327b3db...882af4c. Read the comment docs.

redahas commented 4 years ago

@chgasparoto Great! Thank a mill :)

Made the update. Is that what you had in mind? fix #33 ?

chgasparoto commented 4 years ago

@redahas I just merged other PR into master. Could you please fix the conflict?

redahas commented 4 years ago

@chgasparoto no problem mate. Thats done now. Cheers! 👍

chgasparoto commented 4 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: