chgasparoto / aws-polly-voices

:package: Helper module to get AWS polly voices in an idiomatic way :baby_chick:

https://www.npmjs.com/package/aws-polly-voices

MIT License

4 stars 17 forks source link

feat: add helper method for Swedish #65

Closed mcrosby114 closed 4 years ago

mcrosby114 commented 4 years ago

This adds a helper method for the Swedish language (Issue #7).

Proposed changes

Adds a helper method and a test. Also reorganizes language helper methods to be in alphabetical order.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

codecov-io commented 4 years ago

Codecov Report

Merging #65 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #65   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          38     39    +1     
  Branches        3      3           
=====================================
+ Hits           38     39    +1

Impacted Files	Coverage Δ
src/index.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22f415a...3fe01a1. Read the comment docs.

mcrosby114 commented 4 years ago

It seems it's not synced with master. Could you please take a look. There are too many changes.

Sure, I'll take a look this evening. I was attempting to put the languages in alphabetical order. There may have been subsequent PR merges since I opened this.

mcrosby114 commented 4 years ago

@chgasparoto my original changes had no conflict with master, but to make it easier I've reverted changing the alphabetical ordering of functions in index.js. Now it is simply adding Swedish support.

chgasparoto commented 4 years ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: