search

chhantyal / taggit-selectize

Auto-complete/auto-suggestion for django-taggit (django-taggit + selectize.js)
BSD 3-Clause "New" or "Revised" License
68 stars 23 forks source link

For compatibility #13

Closed c4ys closed 6 years ago

chhantyal commented 6 years ago

Hi, thank you for pull request.

I would prefer try/except pattern over version check.

try:
    from django.urls import reverse
except ImportError:
    from django.core.urlresolvers import reverse

I think this is pattern Django itself follows. Once you update the pull request, I am happy to merge and release new version.

vdboor commented 6 years ago

I've pushed a try..except version in pr #14

chhantyal commented 6 years ago

Thank you @c4ys and @vdboor

I made a new release https://pypi.org/project/taggit-selectize/2.4.0/

pip install taggit-selectize==2.4.0

vdboor commented 6 years ago

Wonderful! I'm glad to see one more dependency fixed that blocked Django 2.0! 👍