Problem using digits - Githubissues

chhh / batmass

Mass spectrometry data visualization

https://batmass.org

Apache License 2.0

36 stars 8 forks source link

Problem using digits #3

Closed Mystilivia closed 7 years ago

Mystilivia commented 7 years ago

Hello, Great job on this tool ! I encounter a problem when I try to search for precise mass using digits, in the example windows it shows 'coma', and when I enter the separator, I can only use period, which returns an error (see below).

go to

Returned error : information

Same with XIC :

which return full tic without subsetting anything. I tried to change the system language settings to use period instead of coma, but it doesn't work.

chhh commented 7 years ago

Hi, this is definitely related to system locale settings, I'll fix that!

chhh commented 7 years ago

@Mystilivia By the looks of screenshots you're on Win7. What are your system regional settings? I can't seem to force it to use commas even when I set it as a decimal separator in the system settings. Can you please start BatMass and go to View -> IDE Log and post the contents here? It has the information about the locale.

I've pushed an update that allows input of commas into those text fields and changed how they are parsed. Just restart BatMass, you should get a notification about available updates. You'll get a warning that the updates are not signed, that's ok, they are always that way. If that won't be enough, I'll need to investigate further.

Mystilivia commented 7 years ago

@chhh My system is on Win7 in French :

On my side too, changing system default settings to use periods doesn't affect the software.

Thanks for the update, now when I open the 'Go To' tools, it shows a comma by default in the input box, and when I enter value, forcing comma, it works !

Idem for XIC, it works well.

The only drawback is when using the digits key on the numeric pad. It uses the period by default, which is not recognised by the soft on my system. It seems that maybe Batmass uses system regional settings for display, but doesn't use them for input ?

chhh commented 7 years ago

@Mystilivia Have you tried using dots in the input? Theoretically I've just changed the text fields to allow dots and commas, and before parsing the numbers, it replaces all occurrences with just a single dot and then parses. So it should work. But as I said, I wasn't able to confirm that so far.

When you type on the numpad does it print the dots? If it prints, what happens after you press OK?

Mystilivia commented 7 years ago

@chhh You are right, using dots actually works :

resulting in :

Thanks for solving this issue !

chhh commented 7 years ago

You're welcome!