search

chhoumann / DemoVault

Demo vault for Obsidian stuff by Christian.
155 stars 47 forks source link

Progress Bar broken with Dataview 0.5.34 #3

Closed AwkwardSandwich closed 1 year ago

AwkwardSandwich commented 2 years ago

Hello,

When downloading the DemoVault and upgrading Dataview to the 0.5.34 version, the progress bars only display \<HTMLDivElement>.

image

Thank you!

MrDuderino2U commented 2 years ago

I was trying to adapt the dashboard as I think it is so cool, but was running into this issue on my personal vault. Three hours later after trying to even copy the exact templates and quick add setup removing mine, it was still not working I found this. I verified it by updating this vault's dataview plug-in and the above error is present.

MrDuderino2U commented 2 years ago

Just a quick comment, it is impacted with Dataview 0.5.33 as well.

n3rdbuddy commented 2 years ago

Modify the last line in view.js from dv.paragraph(containerEl) to dv.paragraph(containerEl.innerHTML)

MrDuderino2U commented 2 years ago

That fixed it, thank you!!

n3rdbuddy commented 2 years ago

Modify the last line in view.js from dv.paragraph(containerEl) to dv.paragraph(containerEl.innerHTML)

I'd be happy to make a PR if that's a thing... :)

chhoumann commented 1 year ago

Hi!

Thank you for raising this. I've never had the issue, which is pretty odd. But using innerHTML doesn't break the system, so I've pushed an update to the main branch where views use innerHTML. Then we're sure compatibility is 👍