search

chhoumann / quickadd

QuickAdd for Obsidian
https://quickadd.obsidian.guide
MIT License
1.57k stars 141 forks source link

fix: use frontmatterPosition end line #750

Closed edongashi closed 3 weeks ago

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quickadd ✅ Ready (Inspect) Visit Preview Nov 3, 2024 0:57am
chhoumann commented 3 weeks ago

Hey @edongashi, thank you for taking the time to contribute!

It looks like the API may have changed since this was originally merged, IIRC. Glad you wrote a fix!

Your PR doesn't resolve #647 because that regards Templates, whereas this modifies code for Captures. So I removed the fix from your PR body to prevent that issue from closing when I merge this.

github-actions[bot] commented 3 weeks ago

:tada: This PR is included in version 1.11.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

edongashi commented 3 weeks ago

Thank you @chhoumann!

It looks like the API may have changed since this was originally merged, IIRC. Glad you wrote a fix!

The API change was acknowledged in the previous PR #595, but I think by accident the wrong line was deleted here

Your PR doesn't resolve https://github.com/chhoumann/quickadd/issues/647 because that regards Templates, whereas this modifies code for Captures.

Thanks for being vigilant, I tried to do some housekeeping given the large number of issues. I gave the issue a second look, and I don't see how this related to templates. Can you please double check?

chhoumann commented 3 weeks ago

Of course. The contents of the issue sounds more relevant to a Capture, but specifically mentions a setting that is only available in Templates: image

I checked & can recreate the issue they presented with the setting. You would have to set the file name to be the same as the file name of an existing file. Then it would try to create the note, notice there's already a file, and instead proceed by simply adding the text to the top of the note, disregarding the frontmatter.

edongashi commented 3 weeks ago

Understood, thanks and keep up the good work!

chhoumann commented 3 weeks ago

Thank you, likewise!