search

chi-rei-den / Localizer

Package based Terraria mod (tModLoader) localization manager and maker. No mod file modification needed.
https://mirror.sgkoi.dev/
GNU General Public License v3.0
203 stars 21 forks source link

Question about subscription syntax #59

Open farnic0 opened 2 years ago

farnic0 commented 2 years ago

1 1_1 Worked

2 2_1 Worked

4 4_1 Didn't work :(

It still didn't work on UpdateArmorSet, Boss Checklist, etc. Is it normal that it doesn't work?

sgkoishi commented 2 years ago

This is the feature of the tModLoader.

https://github.com/tModLoader/tModLoader/blob/206196e2463d4e92545162153977cc8f8907e876/patches/tModLoader/Terraria.ModLoader/ModContent.cs#L578

ProcessCopyCommandsInTexts only works for localized content in the dictionary, so it is not guaranteed to work for all ldstr entries. In fact, most entries are likely not being handled by this function.

The support for this syntax is planned everything planned but nobody actually works on them 😂