chiageng / pe

0 stars 0 forks source link

Edit Command error message is not specific #10

Open chiageng opened 3 months ago

chiageng commented 3 months ago

Justification : User will always edit and insert wrong information while editing, hence medium. Even though is similar with add, since is different command hence i treat as different bug

/edit 240010 :phone 91234567 :email johndoe@example.com 

Output : image.png

Expected : This email address is already exist (since i have already created an employee with same email address)

(But honestly, the duplication catching using phone number and email is very detailed, if able to handle error message more specifically, it will definetely be a really good product)

nus-pe-bot commented 2 months ago

Team's Response

Thank you for the feedback but we do not consider this as a valid concern. We believe correct error message is shown and this is correct behaviour of the app.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This issue is raised because you are using two field as your identifier. To detect duplicate contact, your app use phone number and email.

User will not be able to know which field is duplicated since the error message is too vague. In this case, the email is already exist in contact book but not the phone number. Without displaying to user that duplicate email is detected, user will not be able to continue execute this command. There might be a case where user mistaken phone number is duplicated hence continuously edit phone number but will not have any progress using this app since error message is still too vague.

image.png

Since your team believe that it is expected bahaviour and should not categorized as functionality bug, then this will fall into feature flaw as your team fail to consider user experience and the error message will cause inconvenience to user.

Since this is one of the basic command that will be always executed by user, hence the severity will maintained as medium.