chiageng / pe

0 stars 0 forks source link

Input name not checking for incorrect spacing #13

Open chiageng opened 5 months ago

chiageng commented 5 months ago

Justification: Fast typist tends to press multiple spaces which alter the input into wrong input

/add :name John          Doe :phone 91244567 :email johnd444oe@email.com :address 12Kent Ridge Dr :year 2024 :tag Software Developer :tag Finance

Output :

image.png

Expected : The space is being parsed and remove extra whitespace

(this is one of the example in CS2103T guide, but honest speaking, this project is too good, hard to find bugs)

nus-pe-script commented 5 months ago

Team's Response

Thank you for the feedback but we do not believe this is an issue. Keeping spaces is the correct behaviour of our application to allow users to have the freedom of entering names of all possible kinds.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Direct quote from CS2103T guide on feature flaw

image.png

Similarly, extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons.

I understand that it is correct behaviour for the app, hence it is not considered as functionality bug, in fact it is categorized as feature flaw as you missed out the consideration of different scenario.