search

chiageng / pe

0 stars 0 forks source link

Edit command not having specific message for invalid tag edit #14

Open chiageng opened 5 months ago

chiageng commented 5 months ago

Justification : User will always forget about format of command, and might try to edit a tag that is not exist, hence severity medium

/edit 240001 :email johndo124421e@example.com :tag 1 friend :tag 2 test

Output : image.png

Expected : Tag edited is not exist (This contact only have one tag, but the error display is not justifying the error occur). When i remove tag 2 then the command can execute normally

soc-pe-bot commented 5 months ago

Team's Response

Thank you for your feedback and we believe the wrong error message is shown in this case. This appears only in very rare situations and causes a minor inconvenience, so this should be of low severity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: The error message shown is wrong. Edit command is one of the basic command that will be always executed by user. When the error message is already wrong, user will not be able know what is happening and unable to execute edit command in most cases, hence causing major inconvenience.

In this case, user will be misleading by this error messages and constantly checking for person index when the person index is correct.

Hence this should not be considered as rare case as there is a clear big bug causing occasional inconvenience to user, hence severity should be maintained as medium.