nus-pe-bot
commented
2 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
More information should be given about duplicate people in the UG
Currently when attempting to add a new person, I encountered some difficulty as the application stated that the person was a duplicate. After some experimentation I found that it was due to the requirements of having unique Name, phone and email. This could perhaps have been stated in the UG as a requirement when adding a new person.
[original: nus-cs2103-AY2324S2/pe-interim#2312] [original labels: severity.Low type.DocumentationBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for your feedback. However, there shouldn't be much difficulties or confusion for the users since each employee within a company typically possesses a unique email address and phone number. As a result, when entering information into PayBack, any duplicate errors or mistakes in the data entry process should become immediately apparent to the user. The current error message would prompt users to review all entered fields, and they should be able to identify which fields have been entered incorrectly and are causing duplicates.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This issue is raised because you are using two field as your identifier. To detect duplicate contact, your app use `phone number` and `email`. User will not be able to know which field is duplicated since the error message is too vague. In this case, the email is already exist in contact book but not the phone number. Without displaying to user that duplicate email is detected, user will not be able to continue execute this command. There might be a case where user mistaken phone number is duplicated hence continuously edit phone number but will not have any progress using this app since error message is still too vague. `The current error message would prompt users to review all entered fields, and they should be able to identify which fields have been entered incorrectly and are causing duplicates.` This will categorized as error message is not specific enough since you require user manually check all fields themselves which drop the user experience and performance of fast typist. Hence, this still have to be considered as feature flaw. This app usually will be used by one single admin to handle a lot of contacts. When cater with high workload, the admin possibly looking at wrong employee name when fill in with other employee details with the name which cause inconvenience to user.  Since this is one of the basic command that will be always executed by user, hence the severity should be raised to medium.
## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** `The current error message would prompt users to review all entered fields, and they should be able to identify which fields have been entered incorrectly and are causing duplicates.` This will categorized as error message is not specific enough since you require user manually check all fields themselves which drop the user experience and performance of fast typist. Hence, this still have to be considered as feature flaw.
Justification : User might input same email/phone for different employee, hence low
This command is modified from the example in UG. Previously, a same ID is used to create a user
Output :
Expected : Error message mentioning that email/phone number is already exist. Most of the time, user It is helpful to display a more specific error message to user.