chiageng / pe

0 stars 0 forks source link

Add Command not supporting special name #8

Open chiageng opened 5 months ago

chiageng commented 5 months ago

Justification: Occasionally, there will be special name, hence low severity

/add :name John s/o special name :phone 11235567 :email johnd1424e@email.com :address 12Kent Ridge Dr :year 2024 :tag Software Developer :tag Finance

Output : image.png

Expected : Allow to add special name

nus-pe-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding person disallows special characters like "/"

image.png Currently the add command prohibits the adding of persons with special characters like "/" in their name. This could be troubling for users whose names contains words like s/o. Slight inconvenience for a small group of people.


[original: nus-cs2103-AY2324S2/pe-interim#2311] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you but we mentioned in user guide the requirement for valid names and we showed correct error messages. This is correct behaviour of our app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This is a common name that app should cater with. Hence the severity can actually raised to medium. Allowing such name will provide more flexibility and improve user experience and cater to different races of person, hence it is considered as feature flaw. So this should not be rejected as your team fail to consider for different races of contacts. `Such overzealous input blocking can be considered a type.FeatureFlaw.` ![image.png](https://raw.githubusercontent.com/chiageng/pe/main/files/b0d16be4-1205-4845-83fd-95c8881dea2c.png)