search

chialab / rna

🚀 Build tools for modern web modules and applications.
https://chialab.github.io/rna/
MIT License
172 stars 21 forks source link

Resolve relative paths using URL constructor and ignore directories #167

Closed edoardocavazza closed 8 months ago

edoardocavazza commented 8 months ago

This PR should fix #164 by changing the way relative paths are resolved. In order to prevent recursion and directories, the plugin now resolves relativa paths using the URL constructor instead of the esbuild resolver.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 031a40c4633eee287409dc9e7460f646384be177

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------------- | ----- | | @chialab/esbuild-plugin-meta-url | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 91.46%. Comparing base (d745e14) to head (031a40c).

Files Patch % Lines
packages/esbuild-plugin-meta-url/lib/index.js 52.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #167 +/- ## ========================================== - Coverage 91.64% 91.46% -0.18% ========================================== Files 36 36 Lines 5865 5883 +18 ========================================== + Hits 5375 5381 +6 - Misses 490 502 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.