chibat / chrome-extension-typescript-starter

Chrome Extension TypeScript Starter
MIT License
2.48k stars 417 forks source link

Opinionated styling, package and code updates #28

Closed TheLartians closed 3 years ago

TheLartians commented 3 years ago

Hey, thanks for this great template! It really helped me get started with Chrome extensions. Doing so, I've made a few adjustments to the starter that make it much more usable for me. I was wondering if some of these changes could be interesting for the original template as well.

I know that these are very opinionated changes, so feel free to simply ignore/close the PR if you are not interested. I could also split anything you find interesting into separate PRs, if you prefer.

Summary of changes

chibat commented 3 years ago

Thanks for your PR. I will refer to it and try to incorporate it partially.

LazyCompiler commented 3 years ago

Very useful change! A worth mentioning thing is that the script "prepare": "./prepare_icons.sh" use the command convert which is part of ImageMagick, so make sure you guys install it before (brew install imagemagick).

chibat commented 3 years ago

@TheLartians I would be grateful if you could create another new PR for the following changes.

TheLartians commented 3 years ago

Sure, I'll create the new PR later today!