search

chibisov / drf-extensions

DRF-extensions is a collection of custom extensions for Django REST Framework
http://chibisov.github.io/drf-extensions/docs
MIT License
1.47k stars 208 forks source link

Fixed PaginationKeyBit #146

Closed tevinjoseph closed 8 years ago

tevinjoseph commented 8 years ago

PaginationKeyBit wasn't working the way it was meant to. It gave same results for all pages.

auvipy commented 8 years ago

test?

tevinjoseph commented 8 years ago

@auvipy PaginationKeyBit is an existing piece of code. So, I believe there are tests written for it. No tests are breaking then, it is working fine, I guess.

auvipy commented 8 years ago

kool

chibisov commented 8 years ago

Come on, guys. First of all tests tests_app.tests.unit.key_constructor.bits.tests.PaginationKeyBitTest are failing.

Second - you've hardcoded page_query_param name as page. If someone uses another name it will fail.

Please, revert it and be more careful. Thank you for contribution.

auvipy commented 8 years ago

@tevinjoseph reverted