Workaround for DRF 3.4.0 compat issue

chibisov / drf-extensions

DRF-extensions is a collection of custom extensions for Django REST Framework

http://chibisov.github.io/drf-extensions/docs

MIT License

1.47k stars 208 forks source link

Closed decentral1se closed 8 years ago

decentral1se commented 8 years ago

Closes #156.

auvipy commented 8 years ago

a change log will also be very helpful

decentral1se commented 8 years ago

OK, I:

auvipy commented 8 years ago

i will merge this pr. if you have time then could you try to fix existing test failures?

decentral1se commented 8 years ago

21 failing tests across 9 jobs? I don't think it's gonna be me ...

auvipy commented 8 years ago

only the 1.8 ones will be OK.

decentral1se commented 8 years ago

In fact, this will need to be extended to accept schema_renderers as per the DRF 3.4.0 docs.

I think we definitely need to see the relevant tests passing ... I'll work on it.

auvipy commented 8 years ago

thanks you :)

stephenemslie commented 8 years ago

+1 This is holding me back from upgrading to drf 3.4.0.

auvipy commented 8 years ago

@lwm do you have anything remaining in this pr?or should i merge it?

decentral1se commented 8 years ago

@auvipy

I have added the **kwargs threading in the workaround and tested it manually.

Please merge. I didn't find time to debug the rest of the unrelated problems.

decentral1se commented 8 years ago

Working on my end, @stephenemslie, can you confirm?

stephenemslie commented 8 years ago

Confirmed working here. Thank you!

decentral1se commented 8 years ago

:beers: :hand:

jplock commented 8 years ago

I just ran into this. Any idea when a new version will be pushed to pypi? Thanks!

auvipy commented 8 years ago

lots of tests are failing, if you could help to pass the 1.8 failures then there is possibility for a pypi release.