search

chibisov / drf-extensions

DRF-extensions is a collection of custom extensions for Django REST Framework
http://chibisov.github.io/drf-extensions/docs
MIT License
1.47k stars 208 forks source link

Started Django 1.11 support #187 #197

Closed MightySCollins closed 7 years ago

MightySCollins commented 7 years ago

This is just a really fix which fixes some of the Tox tests and a bug we where having where no responses where coming back as 304. It looks like Django's parse_tags() (django/utils/http.py) was changed in a Django commit https://github.com/django/django/commit/4ef0e019b7dd3d2bf93b5c705b3b7df9cdb77561to because of issue 27083 to return ETags with the quotes around. Instead of 123 it is now "123".

I have just made it strip out the " characters which is probably a bad fix but it preserves backward compatibility and is nice and simple.

If you have a nicer suggestion let me know so we can use it in our project. Might help @auvipy with #187.

MightySCollins commented 7 years ago

I have just added that but annoyingly the tests probably wont pass. I think there are still 12 failures on the Django 1.11 environment. Ideally I will get them fixed but don't have the time right now as they don't seem to break our app.

auvipy commented 7 years ago

no problem just address the last issues i commented and this will get in.

auvipy commented 7 years ago

are you also using drf 3.6? if so plz send a pr with initial drf 3.6 support there is an open issue too

MightySCollins commented 7 years ago

Yep I did try doing both at the same time but thought that was 'out of the scope'. Ill get it pushed and try and finish off the last few bugs.

auvipy commented 7 years ago

you are most welcome.