chibisov / drf-extensions

DRF-extensions is a collection of custom extensions for Django REST Framework
http://chibisov.github.io/drf-extensions/docs
MIT License
1.47k stars 208 forks source link

version 0.3.1 is not compatible with DRF 3.8 and produces ImportError #226

Closed jberends closed 6 years ago

jberends commented 6 years ago

The version 0.3.1 is not compatible with DRF 3.8. It seems that the master is, but the latest provided release to PyPI apparently not.

It produces an import error in the 0.3.1 code

Error:

  ...
  File ".../site-packages/rest_framework_extensions/routers.py", line 7, in <module>
    from rest_framework.routers import (
ImportError: cannot import name 'replace_methodname'

Culprit code of 0.3.1

# -*- coding: utf-8 -*-
from distutils.version import StrictVersion
from django.core.exceptions import ImproperlyConfigured
from django.core.urlresolvers import NoReverseMatch

import rest_framework
from rest_framework.routers import (
    DefaultRouter,
    SimpleRouter,
    Route,
    replace_methodname,
    ^^^^^^^^^^^^^^^^^^^
)
travis-cramer commented 6 years ago

I've run into the same error. Running drf 3.8.2

auvipy commented 6 years ago

you need to install from master master support 3.8

SultanSGillani commented 6 years ago

It still would be nice to get this in pypy.

jberends commented 6 years ago

yup. Why not package it and release it as a proper release?

auvipy commented 6 years ago

lack of time

jberends commented 6 years ago

Is there anything that we can help you with? Maybe automate the build and upload of packages eg. using twine

I can make a PR...

pip install twine
python setup.py bdist_wheel --universal
twine upload dist/*.whl
auvipy commented 6 years ago

need to revert one commit and some release notes remain actually

bryson commented 6 years ago

Can you add instructions for installing from git to the README at least?

auvipy commented 6 years ago

I will

adrienrusso commented 6 years ago

Same issue here, Still waiting for a new version. Do you have an ETA?

auvipy commented 6 years ago

i have emailed the original author for a new pypi release.

adrienrusso commented 6 years ago

0.4.0 has been released 15 hours ago. Thanks

auvipy commented 6 years ago

please let me know if the pypi release is working well. it's my first release of this package

adrienrusso commented 6 years ago

I have no issue so far. It passes all our checks.

auvipy commented 6 years ago

awesome!