Closed pratyushmittal closed 8 years ago
Hello,
Any news about that ? I'm struggling with pagination as well...
:+1: support for the latest DRF version would be great!
@pratyushmittal hi thanks for your works, would u mind restesting and rebasing against drf 3.3.1?
should consider this #113
@pratyushmittal would you please update the PR to pass the CI build?
Hi @auvipy , it is good to see the reincarnation of this awesome library.
In the pull request, I have dropped the support of old DRF versions (due to the new Pagination Class implementation). I have also included new tests for this. Travis CI is still building against the old tests. Any workaround to see the Travis results for the new tests included?
thanks for your effort. will check CI n your code. I'm also planning to drop support of older versions of DRF and django itself too
:+1: and old python versions ;)
@codingjoe python 2.7, 3.4 and 3.5 will be supported as django supports them.
I have updated the Tox file to test against the latest, LTS and supported python versions.
you need to update travis.yml too :) and keep support of 1.7 for now :)
All the tests are passing except for Django 1.7 on Python 3.5. Django 1.7 did not support 3.5.
This should do it travis.yml
matrix:
allow_failures:
- env: DJANGO="Django<1.8,>=1.7"
python: "3.5"
@codingjoe Thanks. Have excluded Django1.7 for Python 3.5 tests.
I have also changed the hash algorithm used for caching of key constructor from sha256 to md5. SHA256 is inherently meant to be slow as it is meant for security use-cases. For caching we need a faster hash generation only for unique keys. NGINX uses md5 for cache keys.
thanks @pratyushmittal for your works! @codingjoe for your insights!! ;)
Hi Gennady,
I have made a few changes to make drf-extensions compatible with the latest Django Rest Framework. The new versions of Django Rest Framework, since 3.1.0, have introduced some breaking changes, such as the new Pagination classes. The tests pass with these recent versions only.
How about considering to drop the support for earlier versions? We can add some note like:
Thanks for creating and sharing the extensions.