search

chicago-police-violence / data

Dataset about the personnel, use of force, and complaints in the Chicago Police Department
MIT License
7 stars 0 forks source link

Dangling file handles? #19

Closed trevorcampbell closed 3 years ago

trevorcampbell commented 3 years ago

I see in src/utils.py there are open(...) commands without corresponding close() calls (and seemingly not within "with as" blocks). Should probably ensure we close open file objects when we're done with them.

Thibauth commented 3 years ago

Good point. However, I can only see one, in the csv_read function but mention "commands" suggesting there are multiple ones, did I miss any?

trevorcampbell commented 3 years ago

I think I may have just seen that one and decided to create a general "look for instances of this problem" thread! So if there's only one, there's only one.