This allows admins to select pick-up and drop-off times when creating or updating a reservation and adds a requirement that the pick-up time must be selected before a reservation becomes "requested"
Members can also add these times when creating a reservation but at the moment there doesn't seem to be a way for them to edit a reservation without typing in the url.
Why it is important
Implements #1526
UI Change Screenshot
New reservation selecting a pickup time:
New reservation selected pickup time:
New reservation validation errors:
Show reservation with pickup/dropoff times
Requesting a reservation without a pickup time:
Member reservation show with pickup/dropoff times:
Implementation notes
The reservation now belongs to a pickup event and dropoff event (both optionally). Moving the reservation from "pending" to "requested" (but really basically any other status) requires the pickup event. This will probably need to be updated once canceling or duplicating or other reservation features are implemented.
If someone goes to edit a reservation where the pickup or dropoff events have already passed they'll still appear in the edit dropdowns.
What it does
This allows admins to select pick-up and drop-off times when creating or updating a reservation and adds a requirement that the pick-up time must be selected before a reservation becomes "requested"
Members can also add these times when creating a reservation but at the moment there doesn't seem to be a way for them to edit a reservation without typing in the url.
Why it is important
Implements #1526
UI Change Screenshot
New reservation selecting a pickup time:
New reservation selected pickup time:
New reservation validation errors:
Show reservation with pickup/dropoff times
Requesting a reservation without a pickup time:
Member reservation show with pickup/dropoff times:
Implementation notes
The reservation now belongs to a pickup event and dropoff event (both optionally). Moving the reservation from "pending" to "requested" (but really basically any other status) requires the pickup event. This will probably need to be updated once canceling or duplicating or other reservation features are implemented.
If someone goes to edit a reservation where the pickup or dropoff events have already passed they'll still appear in the edit dropdowns.