chicago-tool-library / circulate

A lending library management system
Other
81 stars 66 forks source link

Swap member and user relationship #1663

Closed crismali closed 1 week ago

crismali commented 1 week ago

What it does

With these changes members will belong to users instead of users belonging to members.

Why it is important

Having users belong to members is more of a historical artifact than a real design choice. This keeps things to be more like what people would expect.

Implementation notes

I added some SQL to the migration to make sure the current member/user relationships are transferred over. There are probably some other improvements that could be made (like the columns could be non-null if we're sure there's a user for every member or pulling some of the overlap between members and users into a profile, etc), but I focused mainly on inverting the relationship.