chicagoedt / revo_robot

Code for EDT's IGVC entry, Revo.
http://www.igvc.org/
20 stars 23 forks source link

new nodes and uses a superclass to avoid redundant code #65

Closed bsubei closed 9 years ago

bsubei commented 9 years ago

made the equalization and backprojection nodes separate. Also created the brightest-pixel threshold node. Since the topic names are params in the launch file, I was able to create launch files that chain the nodes together (with more nodes, we can check all different combinations)

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/44/ Test Passed.

bsubei commented 9 years ago

don't merge this yet, more nodes on the way

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/45/ Test Passed.

bsubei commented 9 years ago

btw i need to clean up most of these nodes because they're using a lot of configs and variables that are common to all of them (but each node is specific and uses only some of them)

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/46/ Test Passed.

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/47/ Test Passed.

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/48/ Test Passed.

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/49/ Test Passed.

chicagoedt commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://jenkins.chicagoedt.org/job/Software_IGVC_Upstream/50/ Test Passed.

l0g1x commented 9 years ago

@wfriedl Can you take a look at this since you know the most python?

bsubei commented 9 years ago

thanks for the tips, I'll work on these as soon as I'm back in Chicago

l0g1x commented 9 years ago

test this please

bsubei commented 9 years ago

@wfriedl check it out 7d8b779c5a15581e4ef0815b55a06d17027504f1 I also improved it by using izip instead of just zip, which uses the iterator and avoids creating another big array (or image)

That video you linked was really good, I need to become better at Python :)