search

chicagoedt / revo_robot

Code for EDT's IGVC entry, Revo.
http://www.igvc.org/
20 stars 23 forks source link

[roboteq_node] move wheels_msg to roboteq_node since it's only used there #7

Closed bsubei closed 9 years ago

bsubei commented 10 years ago

wheels_msg is currently inside base_controller (which doesn't use wheels_msg). Instead, let's define wheels_msg inside roboteq_node (where it is used).

Make sure the CMakeLists for both packages fixes this. Don't want any missing message headers errors popping up

l0g1x commented 10 years ago

roboteq_node uses its own msg type for wheels_msg. Refer to roboteq_node/msg folder

bsubei commented 10 years ago

correct. I just realized that. Will remove wheels_msg from base_controller.

l0g1x commented 10 years ago

Submit a pull request. Don’t push straight to the master

Krystian Gebis University of Illinois - Chicago Chicago EDT - Robotics (Software) Undergraduate Computer Engineering

On Sep 16, 2014, at 10:32 PM, basheersubei notifications@github.com wrote:

correct. I just realized that. Will remove wheels_msg from base_controller.

— Reply to this email directly or view it on GitHub.

bsubei commented 10 years ago

I pushed it to development branch. It builds on my system. Try it on yours.

bsubei commented 10 years ago

can someone test this to confirm?