search

chicagopython / chipy.org

Chicago Python (ChiPy) user group main website codebase
http://www.chipy.org/
MIT License
115 stars 79 forks source link

101 warnings when running unit tests #538

Open eevelweezel opened 1 week ago

eevelweezel commented 1 week ago

We should probably fix these.

=============================== warnings summary ===============================
../../usr/local/lib/python3.9/site-packages/django/conf/__init__.py:241
  /usr/local/lib/python3.9/site-packages/django/conf/__init__.py:241: RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior.
    warnings.warn(

../../usr/local/lib/python3.9/site-packages/django/conf/__init__.py:289
  /usr/local/lib/python3.9/site-packages/django/conf/__init__.py:289: RemovedInDjango51Warning: The STATICFILES_STORAGE setting is deprecated. Use STORAGES instead.
    warnings.warn(STATICFILES_STORAGE_DEPRECATED_MSG, RemovedInDjango51Warning)

../../usr/local/lib/python3.9/site-packages/sorl/__init__.py:1
  /usr/local/lib/python3.9/site-packages/sorl/__init__.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    from pkg_resources import get_distribution, DistributionNotFound

../../usr/local/lib/python3.9/site-packages/django/conf/__init__.py:193
  /usr/local/lib/python3.9/site-packages/django/conf/__init__.py:193: RemovedInDjango51Warning: The DEFAULT_FILE_STORAGE setting is deprecated. Use STORAGES instead.
    self._show_deprecation_warning(

chipy_org/apps/announcements/tests.py: 1 warning
chipy_org/apps/contact/tests.py: 2 warnings
chipy_org/apps/job_board/tests/test_models.py: 1 warning
chipy_org/apps/job_board/tests/test_views.py: 9 warnings
chipy_org/apps/main/tests.py: 2 warnings
chipy_org/apps/meetings/tests/test_rsvps.py: 5 warnings
chipy_org/apps/meetings/tests/tests.py: 3 warnings
chipy_org/apps/profiles/tests/test_organizers.py: 2 warnings
chipy_org/apps/profiles/tests/test_smoke.py: 1 warning
chipy_org/apps/sponsors/tests.py: 3 warnings
  /usr/local/lib/python3.9/site-packages/django/conf/__init__.py:348: RemovedInDjango51Warning: The STATICFILES_STORAGE setting is deprecated. Use STORAGES instead.
    warnings.warn(STATICFILES_STORAGE_DEPRECATED_MSG, RemovedInDjango51Warning)

chipy_org/apps/contact/tests.py: 3 warnings
chipy_org/apps/job_board/tests/test_views.py: 15 warnings
chipy_org/apps/main/tests.py: 3 warnings
chipy_org/apps/meetings/tests/test_rsvps.py: 6 warnings
chipy_org/apps/meetings/tests/tests.py: 10 warnings
chipy_org/apps/profiles/tests/test_smoke.py: 5 warnings
chipy_org/apps/talks/tests/views/test_topics.py: 25 warnings
  /usr/local/lib/python3.9/site-packages/django/core/serializers/base.py:22: RemovedInDjango50Warning: PickleSerializer is deprecated due to its security risk. Use JSONSerializer instead.
    warnings.warn(

chipy_org/apps/meetings/tests/tests.py::test_my_talks_with_multiple_presenters_with_same_user
  /usr/local/lib/python3.9/site-packages/django/views/generic/list.py:91: UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list: <class 'chipy_org.apps.meetings.models.Topic'> TopicsQuerySet.
    return self.paginator_class(

-- Docs: https://docs.pytest.org/en/stable/warnings.html
================= 70 passed, 1 skipped, 101 warnings in 12.75s =================
elmq0022 commented 1 week ago

Yeah would be nice to have those cleared before an upgrade 🙂

Sent from Proton Mail Android

-------- Original Message -------- On 10/30/24 8:36 PM, Heather White wrote:

We should probably fix these.

=============================== warnings summary =============================== ../../usr/local/lib/python3.9/site-packages/django/conf/init.py:241 /usr/local/lib/python3.9/site-packages/django/conf/init.py:241: RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior. warnings.warn(

../../usr/local/lib/python3.9/site-packages/django/conf/init.py:289 /usr/local/lib/python3.9/site-packages/django/conf/init.py:289: RemovedInDjango51Warning: The STATICFILES_STORAGE setting is deprecated. Use STORAGES instead. warnings.warn(STATICFILES_STORAGE_DEPRECATED_MSG, RemovedInDjango51Warning)

../../usr/local/lib/python3.9/site-packages/sorl/init.py:1 /usr/local/lib/python3.9/site-packages/sorl/init.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html from pkg_resources import get_distribution, DistributionNotFound

../../usr/local/lib/python3.9/site-packages/django/conf/init.py:193 /usr/local/lib/python3.9/site-packages/django/conf/init.py:193: RemovedInDjango51Warning: The DEFAULT_FILE_STORAGE setting is deprecated. Use STORAGES instead. self._show_deprecation_warning(

chipy_org/apps/announcements/tests.py: 1 warning chipy_org/apps/contact/tests.py: 2 warnings chipy_org/apps/job_board/tests/test_models.py: 1 warning chipy_org/apps/job_board/tests/test_views.py: 9 warnings chipy_org/apps/main/tests.py: 2 warnings chipy_org/apps/meetings/tests/test_rsvps.py: 5 warnings chipy_org/apps/meetings/tests/tests.py: 3 warnings chipy_org/apps/profiles/tests/test_organizers.py: 2 warnings chipy_org/apps/profiles/tests/test_smoke.py: 1 warning chipy_org/apps/sponsors/tests.py: 3 warnings /usr/local/lib/python3.9/site-packages/django/conf/init.py:348: RemovedInDjango51Warning: The STATICFILES_STORAGE setting is deprecated. Use STORAGES instead. warnings.warn(STATICFILES_STORAGE_DEPRECATED_MSG, RemovedInDjango51Warning)

chipy_org/apps/contact/tests.py: 3 warnings chipy_org/apps/job_board/tests/test_views.py: 15 warnings chipy_org/apps/main/tests.py: 3 warnings chipy_org/apps/meetings/tests/test_rsvps.py: 6 warnings chipy_org/apps/meetings/tests/tests.py: 10 warnings chipy_org/apps/profiles/tests/test_smoke.py: 5 warnings chipy_org/apps/talks/tests/views/test_topics.py: 25 warnings /usr/local/lib/python3.9/site-packages/django/core/serializers/base.py:22: RemovedInDjango50Warning: PickleSerializer is deprecated due to its security risk. Use JSONSerializer instead. warnings.warn(

chipy_org/apps/meetings/tests/tests.py::test_my_talks_with_multiple_presenters_with_same_user /usr/local/lib/python3.9/site-packages/django/views/generic/list.py:91: UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list: <class 'chipy_org.apps.meetings.models.Topic'> TopicsQuerySet. return self.paginator_class(

-- Docs: https://docs.pytest.org/en/stable/warnings.html ================= 70 passed, 1 skipped, 101 warnings in 12.75s =================

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

eevelweezel commented 1 week ago

@elmq0022 what are your thoughts on doing this as part of a python version upgrade? With the cadence of deprecations, I'm thinking maybe we should start with upgrading to 3.12, then address warnings.

Also, I'm not that familiar with our deployment process. Are there concerns there?

elmq0022 commented 1 week ago

If we're still on heroku the python version is the primary concern as long as Django and all the other things are compatible iirc.

https://devcenter.heroku.com/articles/python-support

3.9 is deprecated but there's no EOL date. Moving to 3.12 would be great but Django 4.1 only goes to python 3.11 officially.

https://docs.djangoproject.com/en/5.1/releases/4.1/

So probably 3.11, clear errors, and upgrade Django to 5.0?

Sent from Proton Mail Android

-------- Original Message -------- On 10/30/24 10:26 PM, Heather White wrote:

@.***(https://github.com/elmq0022) what are your thoughts on doing this as part of a python version upgrade? With the cadence of deprecations, I'm thinking maybe we should start with upgrading to 3.12, then address warnings.

Also, I'm not that familiar with our deployment process. Are there concerns there?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

eevelweezel commented 1 week ago

This sounds like a good plan.

On Wed, Oct 30, 2024, 22:59 LeakedMemory @.***> wrote:

If we're still on heroku the python version is the primary concern as long as Django and all the other things are compatible iirc.

https://devcenter.heroku.com/articles/python-support

3.9 is deprecated but there's no EOL date. Moving to 3.12 would be great but Django 4.1 only goes to python 3.11 officially.

https://docs.djangoproject.com/en/5.1/releases/4.1/

So probably 3.11, clear errors, and upgrade Django to 5.0?

Sent from Proton Mail Android

-------- Original Message -------- On 10/30/24 10:26 PM, Heather White wrote:

@.***(https://github.com/elmq0022) what are your thoughts on doing this as part of a python version upgrade? With the cadence of deprecations, I'm thinking maybe we should start with upgrading to 3.12, then address warnings.

Also, I'm not that familiar with our deployment process. Are there concerns there?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/chicagopython/chipy.org/issues/538#issuecomment-2448966791, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKYUFIVAETXR3NQOQOEETZ6GTIXAVCNFSM6AAAAABQ5KQ6BCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYHE3DMNZZGE . You are receiving this because you authored the thread.Message ID: @.***>