search

chickendude / Natibo

Breathe new life into your Glossika PDF/MP3 courses!
The Unlicense
26 stars 3 forks source link

Change course detail look #22

Closed jubalh closed 5 years ago

jubalh commented 5 years ago

On some flags it looks a bit strange when we write the name of the language over the flag. It looks like the flag is smaller than it should be because the alpha of 0.9 looks sometimes so dense that I didn't realize that the flag continues behind it.

I experimented a bit with the look and now changed it so the language is displayed above the flag.

This is what it looks like:

natibo

chickendude commented 5 years ago

I don't know that that looks any better, at the very least it should go into the toolbar instead of taking up extra space on the screen. If you don't like the current positioning of the language name, i think it might be best to remove it altogether. We already have the title up top anyway, eventually we should let users name their own courses/give custom course names. What do you think?

jubalh commented 5 years ago

Okay, in your branch I saw that you already changed the title to be Source -> Targetlanguage. I agree that this is better than having the language two times.

I would like to do the other change anyway: Not overlapping the flag with the configure and trash icon and the color. I would place the icons below the flag.

This would also be a way for me to get started contributing here ;)

What do you think about proposed change?

chickendude commented 5 years ago

How about if you move the icons to the right of the Total Reps/Sentences Seen section so they're all in the same row? The only thing is i'm not sure if it'll fit on small screens, we'll have to double-check that first.

jubalh commented 5 years ago

Okay! I'll change this PR on the weekend :)

jubalh commented 5 years ago

Messed up because I did commits to git master. Closing this in favour of https://github.com/chickendude/Natibo/pull/30