search

chickendude / Natibo

Breathe new life into your Glossika PDF/MP3 courses!
The Unlicense
26 stars 3 forks source link

Disallow orientation change to landscape mode #32

Closed flackbash closed 5 years ago

flackbash commented 5 years ago

Previously in the StudySession fragment, an orientation change resulted in the app crashing. In the CourseDetail fragment, an orientation change took the user back to the previous fragment. This commit enforces portrait mode in the entire app to prevent these things from happening. Since in landscape mode some fragments anyhow don't fit into the screen of some phones, I think this solution is preferable over the way things are right now. That way, this could be a (temporary) solution for #9 .

chickendude commented 5 years ago

Personally, i'd prefer to handle orientation changes than get around it with this, i kinda left it like this as a reminder to get around to it, it just hasn't been top priority for me since i've disabled auto-rotate. Though if it's an issue for you i can put it on priority. I'll merge this for now, i'll try to put together some landscape layout files (feel free to do this as well!) and implement onSaveInstanceState() soon.

flackbash commented 5 years ago

Ok, I understand. Great to have it in for now :) It makes studying more comfortable for me if I don't have to worry about turning my phone the wrong way.