search

chickendude / Natibo

Breathe new life into your Glossika PDF/MP3 courses!
The Unlicense
26 stars 3 forks source link

Add option in settings to change playback speed #39

Closed flackbash closed 4 years ago

flackbash commented 4 years ago

This allows the user to adjust the playback speed of the target language audio. The option is only shown for API > 23. This is related to #20.

One thing that is not properly working yet is that the remaining study time is not adjusted correctly when changing the playback speed. In Day.java, L186: I couldn't think of a clean way to check whether a sentence is from the base or the target language and therefore whether to multiply the sentence time with the adjusted playback speed or not. But maybe with the proper understanding of the code base this is not as difficult. Can you think of something @chickendude ?

chickendude commented 4 years ago

Awesome, thanks! I'll take a look at this this weekend to see what i can come up with. At present, the timer isn't always accurate anyway.

flackbash commented 4 years ago

Cool! :)

At present, the timer isn't always accurate anyway.

Yeah, that's why I decided to commit it anyway ;)

chickendude commented 4 years ago

Ok, cool, i've merged the changes, i also filled in the calculation for time, though the timer still has a lot of bugs. Thanks again!