definitelyokay
commented
9 months ago LogicBlocks is such a nice HFSM implementation! I've been in the space of Statecharts and C# and your class-based syntax as well as the way to handle bindings are really neat! And the documentation is superb!
@bemayr Thank you so much, that really means a lot!
Might the following code be a small release mistake?
That is indeed a huge mistake, and one that has been bothering me too 😆 I wondered why I had started seeing that happen a lot more...
I develop primarily on macOS with Visual Studio Code. It does not prompt to hook into a debugger, even with that code. I would switch to my Windows PC to debug the source generator if I got stuck while working on it. Hence why that statement slipped through haha.
Unrelated, but since you are the right audience:
As you can tell, the logic blocks generator was very much an "experimental" project — I needed this for my game project, after all, and didn't want to spend forever creating a more robust generator (I spent many months on another generator project and I was a little burnt out by the time I got around to finishing this).
That being said, if you have ideas on making the generator more sound, I'm totally open to them. There will always be cases where you can return next states that it can't detect the exact types of, but there could probably be a number of improvements made so that situations like that would be far less common. In all fairness, the generator needs a complete overhaul. So if you ever feel like you want to redo it, by all means please do ;)
bemayr
First of All 🥳
LogicBlocks is such a nice HFSM implementation! I've been in the space of Statecharts and C# and your class-based syntax as well as the way to handle bindings are really neat! And the documentation is superb!
Bug 🐞 (a really small one)
Now to the one thing I recently discovered, I am currently in the process of using LogicBlocks to manage Websocket connections. I'm using VS 2022 and discovered that it wants to launch a JIT compiler at startup as well as on a full rebuild. It took me a bit of time to figure out that the problem arises from the LogicBlocks.Generator plug-in, because Visual Studio is incapable of debugging itself in this aspect. Dismissing the dialog lets one easily continue working on the project, but it gets a bit tedious that the dialog appears every time the source generator is run.
Potential Solution 👀
I then started to dig into the Generator a bit (I've also been developing generators over the last couple of months quite a bit and you got some really useful ideas/solutions regarding generator/analyzer debugging in there 💯). Might the following code be a small release mistake? In the sense that you simply forgot to remove the newline between the comment and the
Debugger.Launch()call, so that the debugger gets launched everytime? I wonder why and if this works using a VSCode or Rider setup, or whether it is some other misconfiguration on my side...https://github.com/chickensoft-games/LogicBlocks/blob/2ba212bf482668275ac2a1d4a7eeb1b0d67c96ce/Chickensoft.LogicBlocks.Generator/src/LogicBlocksGenerator.cs#L29-L34