search

chico2121 / bpe

MIT License
27 stars 11 forks source link

Code error #4

Closed ygywdr closed 3 years ago

ygywdr commented 3 years ago

In unity_base_dataset.py line 67, the self.character_names is wrong. I guess it is not the latest. And I can't run it now.

chico2121 commented 3 years ago

My apologize for the inconvenience. The character names have been corrected to match the SARA dataset.

ygywdr commented 3 years ago

@chico2121 Line 95 in unity_base_dataset.py, 'glob_path' does not match the dataset. And I'm sure this is not the last discrepancy. Could you provide the dataset used for the experiment or the latest code?

BAILOOL commented 3 years ago

@ygywdr I also experienced the same problem when running the code. I am currently working on PR to fix the discrepancies. Will be coming soon.