search

chicommons / maps

MIT License
6 stars 18 forks source link

Coop Spreadsheet View - Resolves #190 #200

Closed domdelorenzo closed 2 years ago

domdelorenzo commented 2 years ago

Updated spreadsheet component (available at http://localhost:3001/spreadsheet in docker) now spawns an update modal window that can update Coop records.

Outstanding question:

laredotornado commented 2 years ago

Hi, Answer is, we don't. "proposed changes" is only for people who submit coop edit/add data for an admin to approve. THis column should definitely be suppressed in the spreadsheet view.

Thanks! -

On Wed, Jun 15, 2022 at 7:11 PM domdelorenzo @.***> wrote:

Updated spreadsheet component (available at http://localhost:3001/spreadsheet in docker) now spawns an update modal window that can update Coop records.

Outstanding question:

  • How do we want to display data for the "proposed changes" column? (it's currently a json object - do we want to stringify it in the spreadsheet?)

You can view, comment on, or merge this pull request online at:

https://github.com/chicommons/maps/pull/200 Commit Summary

File Changes

(11 files https://github.com/chicommons/maps/pull/200/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/chicommons/maps/pull/200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRHTSLQIFQXFATRPDVRGADVPJWK7ANCNFSM5Y5BBHLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

domdelorenzo commented 2 years ago

@laredotornado, I removed "proposed_changes" from the serializer and fixed some of the sloppy formatting. I've also updated the apache config, but I'm not sure how to test it. Let me know what I should be looking at and I'll take a look!

laredotornado commented 2 years ago

Sadly right now, after updating the Apache configs you have to rebuild the docker containers

docker-compose down --rmi all
docker-compose up

After that's done, you should be able to interact with your spreadsheet

http://loaclhost:3001/spreadsheet

or hit the new endpoint directly

http://localhost:9090/all

I can also give it a whirl

On Thu, Jun 16, 2022 at 8:40 PM domdelorenzo @.***> wrote:

@laredotornado https://github.com/laredotornado, I removed "proposed_changes" from the serializer and fixed some of the sloppy formatting. I've also updated the apache config, but I'm not sure how to test it. Let me know what I should be looking at and I'll take a look!

— Reply to this email directly, view it on GitHub https://github.com/chicommons/maps/pull/200#issuecomment-1158381893, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRHTSJSY2ERXZLRBW6IAPTVPPJR5ANCNFSM5Y5BBHLQ . You are receiving this because you were mentioned.Message ID: @.***>