search

chicoreus / cco_poc

Proof of concept files for an implementation of an information model for complex natural science collections objects.
GNU General Public License v2.0
1 stars 3 forks source link

executing up.sh, - error when exampledata.sql is parsed #6

Closed Inkimar closed 7 years ago

Inkimar commented 7 years ago

To be able to run this liquibase-project with maven ( up.sh , contains 'mvn clean install' ) You must upgrade the following files, marked in bold.

pre-req: before you start - notice this. The pom.xml-file points to a file , config/liquibase_cco_full.properties, that is missing.

liquibase_cco_full.properties create the file 'liquibase_cco_full.properties' (config-directory) as done below ( for mysql ) linux-style copy : $ cp liquibase_cco_full.properties.mysqltemplate liquibase_cco_full.properties Then update the username and password

exampledata.sql needs to be reformatted

db.changelog-master.xml include exampledata.sql, see below, if you would like the exampledata ( NB: see previous )

<?xml version="1.0" encoding="UTF-8"?>
<databaseChangeLog
  xmlns="http://www.liquibase.org/xml/ns/dbchangelog/1.9"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog/1.9
         http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-1.9.xsd">
   <include file="edu/harvard/huh/specify/datamodel/cco_full/db/tables.sql"/>
  <include file="edu/harvard/huh/specify/datamodel/cco_full/db/exampledata.sql"/>
</databaseChangeLog>
chicoreus commented 7 years ago

liquibase_cco_full.properties is missing by design, it is expected to contain your database credentials and therefore precautions are taken to make it difficult for you to inadvertently commit it and push your credentials to public view. The documentation states that you must create this file from one of the templates before you run maven. Won't fix this, it is a feature.

exampledata.sql might be included - need to extend the pom to use maven profiles to allow for just building the schema, including the example data, and removing the example data (at which point the pom could also have a profile for building cco_poc as well as cco_full. As of yet, exampledata.sql isn't included in the liquibase build. This feels like it fits with the whole liquibase configuration isn't stable yet part of the documentation.

chicoreus commented 7 years ago

This should be resolved in f571785d36cafe1347be7fc49a69ff8bc19fe9fb Added a profile to maven (mvn clean install -P cco_full_examples) that does a build including the examples.sql file. Corrections made to tables.sql and examples.sql so that it runs with liquibase without failing.