search

chidiwilliams / buzz

Buzz transcribes and translates audio offline on your personal computer. Powered by OpenAI's Whisper.
https://chidiwilliams.github.io/buzz
MIT License
11.81k stars 884 forks source link

Fix for snap build #753

Closed raivisdejus closed 3 months ago

raivisdejus commented 3 months ago

Created a custom version of CTranslate2 wheel that has libctranslate2.so with stripped execstack flags. Local validation of the snap passes and it works as with the default CTranslate2 wheel file. Build notes of the custom CTranslate wheel are here. https://github.com/raivisdejus/CTranslate2-no-execstack/

For snap build to fit GitHub actions environment limits I am switching to CPU torch in the snap. That is a version that will work for every user, for users with GPUs will attempt to install GPU specific torch in a later PR.

Also removed locales-all from snap as it is not needed and takes a lot of space in snap.

Also restoring previously disabled whisper types on Linux.

This PR also includes fix for macOS build from https://github.com/chidiwilliams/buzz/pull/751

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 81.46%. Comparing base (38f5d26) to head (72e309e). Report is 9 commits behind head on main.

:exclamation: Current head 72e309e differs from pull request most recent head dd57e45

Please upload reports for the commit dd57e45 to get more accurate results.

Files Patch % Lines
buzz/file_transcriber_queue_worker.py 17.39% 19 Missing :warning:
buzz/widgets/recording_transcriber_widget.py 22.22% 14 Missing :warning:
buzz/widgets/transcription_task_folder_watcher.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #753 +/- ## ========================================== + Coverage 81.28% 81.46% +0.18% ========================================== Files 81 83 +2 Lines 3617 3928 +311 ========================================== + Hits 2940 3200 +260 - Misses 677 728 +51 ``` | [Flag](https://app.codecov.io/gh/chidiwilliams/buzz/pull/753/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chidi+Williams) | Coverage Δ | | |---|---|---| | [Windows](https://app.codecov.io/gh/chidiwilliams/buzz/pull/753/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chidi+Williams) | `81.17% <44.61%> (-0.12%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/chidiwilliams/buzz/pull/753/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chidi+Williams) | `81.16% <50.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chidi+Williams#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raivisdejus commented 3 months ago

Will merge cleaned up version of this PR via https://github.com/chidiwilliams/buzz/pull/757