search

chiefbiiko / dynamodb

deno <3 dynamodb
MIT License
25 stars 11 forks source link

default port 80 not 443? #11

Closed mbonig closed 4 years ago

mbonig commented 4 years ago

When establishing the connection in the derive_config:

https://github.com/chiefbiiko/dynamodb/blob/master/client/derive_config.ts#L47

you are assuming a default port of 80. DynamoDB requires a 443 so why is that not the default?

chiefbiiko commented 4 years ago

thanks, definitely need to change that!

mbonig commented 4 years ago

https://github.com/chiefbiiko/dynamodb/pull/12

hayd commented 4 years ago

~In deno-lambda had to do this in order to support both regular use and test: https://github.com/hayd/deno-lambda/blob/master/example-serverless/client.ts#L8~

Edit: This default in 12 is better.

hayd commented 4 years ago

close?

mbonig commented 4 years ago

appears resolved now in v0.3.0