search

chieffancypants / angular-hotkeys

Configuration-centric keyboard shortcuts for your Angular apps.
http://chieffancypants.github.io/angular-hotkeys/
MIT License
1.68k stars 248 forks source link

Contenteditable issue #152

Closed shlajin closed 9 years ago

shlajin commented 9 years ago

Hello! I ran into a problem when there is no possibility of making keys work when focus is inside the contenteditable tag. I believe this should come as an option in allowIn array, just like TEXTAREA, INPUT or SELECT.

Thanks!

chieffancypants commented 9 years ago

Makes sense -- can you please squash the commits so it's a bit easier to review?

shlajin commented 9 years ago

Sure, just did it.

chieffancypants commented 9 years ago

Closing due to being out of date with master and no updates after I made some suggestions. If this is still important to you, please open a new PR that has been updated against master.