search

chieffancypants / angular-hotkeys

Configuration-centric keyboard shortcuts for your Angular apps.
http://chieffancypants.github.io/angular-hotkeys/
MIT License
1.68k stars 254 forks source link

memroy #263

Open ideamean opened 7 years ago

ideamean commented 7 years ago

when press the key that bind, the browser's memory is increase higher and higher, why?

aramando commented 7 years ago

@ideamean It's most likely due to the code you've registered as the callback for the hotkey. Can you post it here?

ideamean commented 7 years ago

hotkeys.bindTo($scope).add({ combo: 'left', description: 'action_map_mode_submit', callback: function (event, hotkey) { // even if here is no code, memory will continue to rise // press the "left" key, memory will increase } })

aramando commented 7 years ago

That's weird, I created a Plunk to test and I can't reproduce this. Even after 2000 hotkey presses there was absolutely no increase in the memory used.

Does it depend which browser you use? Can you create a Plunk or similar that demonstrates the issue?