search

chieffancypants / angular-hotkeys

Configuration-centric keyboard shortcuts for your Angular apps.
http://chieffancypants.github.io/angular-hotkeys/
MIT License
1.68k stars 254 forks source link

mousetrap belongs in bower.json dependencies, not devDependencies #265

Open erikdonohoo opened 7 years ago

erikdonohoo commented 7 years ago

If mousetrap is not in dependencies, then each bower user of this library is required to have their own explicit dependency on mousetrap. Please move this from devDependencies to dependencies.

aramando commented 7 years ago

The distribution builds of angular-hotkeys in build/ already contain the Mousetrap library, so users have no need of a separate dependency. Only developers working on src/angular-hotkeys.js need the separate Mousetrap library, so it is in fact a devDependency.