Hotkey does not fire when changing routes in ngRoute - Githubissues

chieffancypants / angular-hotkeys

Configuration-centric keyboard shortcuts for your Angular apps.

http://chieffancypants.github.io/angular-hotkeys/

MIT License

1.68k stars 254 forks source link

Hotkey does not fire when changing routes in ngRoute #270

Open gentisaliu opened 7 years ago

gentisaliu commented 7 years ago

Suppose I have two ngRoutes, route1 and route2, where route1 shows a list of companies and route2 displays details about that company.

In route2 I want hotkeys to work (Ctrl + Up ). When I first visit route2 for a company, the hotkey binding works. Then when I go back to route1 and select another company (even the same), the hotkey is no longer firing.

Is my configuration wrong or is this a bug?

Plunkr which reproduces the issue: http://plnkr.co/edit/wnpchyabeKGuciDJ6H5E?p=preview

aramando commented 7 years ago

@gentisaliu This is a bug, which I've fixed in the above PR. It's unlikely to get merged, though; @chieffancypants hasn't been responding for a long time. Feel free to use my fork.