chieffancypants / angular-loading-bar

A fully automatic loading / progress bar for your angular apps.
https://chieffancypants.github.io/angular-loading-bar/
MIT License
5.17k stars 682 forks source link

Fix endless timeout loop #364

Open xemle opened 7 years ago

xemle commented 7 years ago

What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide

_inc() does not change the status if status is larger or equal than 0.99. So no new $timeout promises need to be created if status >= 0.99.

This will fix some issues with protractor which waits until all $timeout promises are completed. Before new $timeout promises where created again and again and protractor timeouts occurred.

Have you provided unit tests that either prove the bugfix or cover the enhancement?

Test provided that no new $timeout is created after status reaches 0.99

Related issues

337