chieffancypants / angular-loading-bar

A fully automatic loading / progress bar for your angular apps.
https://chieffancypants.github.io/angular-loading-bar/
MIT License
5.17k stars 682 forks source link

doesn't work when using ngAnimate #5

Closed skeenan closed 11 years ago

skeenan commented 11 years ago

doesn't work at all when using ngAnimate

chieffancypants commented 11 years ago

Could you elaborate a bit on what specifically isn't working? The example page is using ngAnimate and is obviously working. Does it work for you when using the example?

skeenan commented 11 years ago

Yes the example page does work for me.

w.r.t using it in my own application, the problem is quite straightforward.

This works, i.e. we get the progressbar

 angular.module('myApp', ["ui", "ui.bootstrap","ngResource", "ngGrid","ngSanitize","chieffancypants.loadingBar","ngRoute"])   

This doesn't work. i.e we don't get the progressbar

 angular.module('myApp', ["ui", "ui.bootstrap","ngResource", "ngGrid","ngSanitize","chieffancypants.loadingBar","ngRoute","ngAnimate"])   
chieffancypants commented 11 years ago

Are you using the supplied CSS file or your own? The only thing ngAnimate does is add css classes that you can use to define how you want the transitions to look. When you don't include ngAnimate, it'll simply insert/remove the object into the DOM and not apply any CSS classes. Therefore it should always work regardless of whether ngAnimate is included, unless your CSS is applying strange styles

So a few things you can check:

chieffancypants commented 11 years ago

I'm going to close this since I haven't heard back. Feel free to re-open if you still think this is an issue with the loading bar.