search

chiefonboarding / ChiefOnboarding

Free and open-source employee onboarding platform. Onboard new hires through Slack or the web portal.
https://chiefonboarding.com
GNU Affero General Public License v3.0
681 stars 126 forks source link

Add PDF embed viewer #307

Open joenilson opened 1 year ago

joenilson commented 1 year ago

As there is a viewer for videos uploaded, there must to be a viewer for pdf uploaded.

This is add to _content.html the pdf embed or object tag in the attached if.

Working with this to do a PR.

GDay commented 1 year ago

Interesting idea. I only use FF and it has a build-in pdf reader when I open PDF files. I am not entirely sure about other browsers, but I wonder if embedding PDF files would add a lot of value.

When I think of a PDF file, I generally think of large text documents or forms that need to be filled in. So I am not sure if embedding these would work that well, since the PDF would show up a lot smaller inline.

joenilson commented 1 year ago

In this case, when you have a new hire you want them to see your privacy policy or some document with the company principles or ISO certification information.

This documents commonly are one or two pages, as they could be controlled documents can't converted as images and are required that the new hire see and acknowledge read it.

That is why embed a pdf file is functional and it allows to the human resources department to incrust his documents without converting or sharing externally.