search

chiefonboarding / ChiefOnboarding

Free and open-source employee onboarding platform. Onboard new hires through Slack or the web portal.
https://chiefonboarding.com
GNU Affero General Public License v3.0
667 stars 122 forks source link

Add check for manager and buddy assigned to user where required #398

Closed GDay closed 10 months ago

GDay commented 10 months ago

New hires can have a manager/buddy assigned to them. These can then be used in content boxes (by using {{ manager }} or {{ manager_email }} or similar ones for a buddy) or they can be used for admin tasks or external messages in sequences to assign tasks to or send messages to.

When a new hire gets assigned a sequences that has those references and the new hire does not have a manager, then those will (silently) fail. In the case of content, it will just display nothing. For admin tasks, this will fail the creation of an admin task.

In most cases, the manager/buddy will be filled for most people, so this will likely not happen often. Though, as a precaution, it will now display a button if that's the case (which leads to the profile page to update the new hire):

image

coveralls commented 10 months ago

Coverage Status

coverage: 93.836% (-0.005%) from 93.841% when pulling 9e737464529cfd920c6b6b76f668e8f499a3d6d6 on add-check-for-admin-and-manager-assigned into a6f2f9a790c2b507b14cf9aa45a1a307bdc88b41 on master.