Add complete and reopen admin task functionality from People/new hire view

chiefonboarding / ChiefOnboarding

Free and open-source employee onboarding platform. Onboard new hires through Slack or the web portal.

https://chiefonboarding.com

GNU Affero General Public License v3.0

640 stars 119 forks source link

Add complete and reopen admin task functionality from People/new hire view #404

Closed JonasMe closed 8 months ago

JonasMe commented 8 months ago

Added "Action" header to "Admin task" table in "new hire -> Admin task" view.

Upon clicking the task will either be completed or reopened and appropiate message displayed.

JonasMe commented 8 months ago

Hi @GDay - Thanks for the feedback. I can see the sense in removing the "reopening" until perhaps there is a lookup-table of executed tasks to prevent rerunning.

I'll remove that option as well as fixing the tests asap.

coveralls commented 8 months ago

coverage: 93.784% (-0.05%) from 93.835% when pulling 5995b16ef9458f015a6209ce34542040e88fd77b on JonasMe:pr/complete-task-from-profile into 075a7168279da0810edd7e498512feaf8ed69c08 on chiefonboarding:master.

JonasMe commented 8 months ago

LGTM! Thanks!

Great to hear @GDay - a whitespace was missing in the auth files which Black dident like. I've reformatted and all should be good to go.