chiefonboarding / ChiefOnboarding

Free and open-source employee onboarding platform. Onboard new hires through Slack or the web portal.
https://chiefonboarding.com
GNU Affero General Public License v3.0
640 stars 119 forks source link

Revoke user accounts when able to from offboarding sequence #405

Closed GDay closed 8 months ago

GDay commented 8 months ago

Previously an offboarding sequence would always trigger the "execute" part of an integration. This is actually not correct in many cases when it's about user provisioning (it would create the user instead of revoking it). With this change, it will revoke the user when revoke is part of the manifest and the user is offboarding. If not, then it will run the "execute" part.

coveralls commented 8 months ago

Coverage Status

coverage: 93.821% (-0.01%) from 93.835% when pulling 64b6b7da0fb195543ccd1c929e8bad0af9ae744b on revoke-user-accounts-in-offboarding-sequences into 075a7168279da0810edd7e498512feaf8ed69c08 on master.