Sequence - Added dragging feedback & minor JS refactoring

chiefonboarding / ChiefOnboarding

Free and open-source employee onboarding platform. Onboard new hires through Slack or the web portal.

https://chiefonboarding.com

GNU Affero General Public License v3.0

640 stars 119 forks source link

Sequence - Added dragging feedback & minor JS refactoring #407

Closed JonasMe closed 8 months ago

JonasMe commented 8 months ago

Added extra visual feedback for dragging in the sequence page by changing cursor to grabbing, adding a tooltip to the "Create new item" and doing negative color if a drag is not possible.

Also refactored some of the JS code to improve maintainability and make it easier to extend with additional validations and types.

GDay commented 8 months ago

The refactoring looks very good. Great work!

coveralls commented 8 months ago

coverage: 93.836% (+0.02%) from 93.821% when pulling 02bf20957bbd70ced3d70431a123a308e7c1d64a on JonasMe:pr/click-to-add-sequence-tool into d31f0fbfc099fc326ed82e92f236014e13a7d2e3 on chiefonboarding:master.